Conversation
See if this renders better.
|
Note to self: Look for more READMEs that need conversion. @ekluzek how should we handle the presence of both a README and a README.md in the /ctsm directory? |
Good question. The README.md shows up as what you see on github. And it's probably something we want to be short, with the main content being what we want people to see when they got to CTSM on github. In contrast, the content of the README details about how to use CTSM and some practical details about how to get around in the checkout. So you could add the content of the plain README to the README.md, but make it at the end. The other option would be to have a file with a different name maybe something like: README_on_CTSM.md? Which sounds better to you? |
|
There are several READMEs to address in Next one to work on: python/ctsm/test UPDATE on the above from a meeting with Erik earlier this afternoon: |
There was a problem hiding this comment.
@ekluzek it occurred to me that maybe I shouldn't be changing .rst files to .md, such as this one (already did it) and README.python_pkgs.rst (I will wait to hear back from you).
There was a problem hiding this comment.
I have started answering my own question. Changing the second of these files caused an error in a github workflow. I will see if changing the first file is a problem, too.
There was a problem hiding this comment.
I was confusing myself:
- The original question still holds, whether it's ok the change README_GITFLEXMOD and README.python_pkgs from .rst to .md
- I had to revert a different file from .md to no suffix (plain text) to correct a failing github workflow:
README.unit_testing
There was a problem hiding this comment.
This note is related, but it's a reminder to myself:
If we keep README_GITFLEXIMOD.md, I now see additional formatting corrections that I would try.
There was a problem hiding this comment.
I would strongly prefer we convert reStructuredText files to Markdown, which is much more human-readable. Having just one markup format would also simplify doc viewing, as users would only need one rendering tool.
|
@samsrabin I will send you a review request:
|
src/README.unit_testing.md
Outdated
There was a problem hiding this comment.
I reversed this replacement with a later commit, but now I see that maybe I just needed to update the following:
.github/workflows/docs-build-and-deploy.yml: - 'src/README.unit_testing'
.github/workflows/docs.yml: - 'src/README.unit_testing'
.github/workflows/docs.yml: - 'src/README.unit_testing'
doc/source/users_guide/testing/testing.rst:.. include:: ../../../../src/README.unit_testing
Similarly should I update these (for a file already in .md format):
.github/workflows/docs-build-and-deploy.yml: - 'tools/README'
.github/workflows/docs.yml: - 'tools/README'
.github/workflows/docs.yml: - 'tools/README'
samsrabin
left a comment
There was a problem hiding this comment.
Great start, Sam, thanks! I've requested some changes and added other comments.
There was a problem hiding this comment.
This file at least appears to be valid Markdown, but it doesn't take advantage of any Markdown features. That's probably acceptable; mark this comment as resolved if you agree.
There was a problem hiding this comment.
It would be better to use the simpler Markdown syntax for section headings, using #, rather than this underlining method.
There was a problem hiding this comment.
The headings could be changed to use Markdown heading syntax (prefix with #, ##), but I don't feel too strongly here.
| @@ -2,32 +2,41 @@ mesh_mask_modifier is a tool that modifies mesh_mask files. It reads a | |||
| mesh_mask file and outputs a modified copy of the same file. | |||
|
|
|||
| Files involved | |||
| -------------- | |||
There was a problem hiding this comment.
"Files involved" should be restored to be a heading.
There was a problem hiding this comment.
It would be better to use the simpler Markdown syntax for section headings, using #, rather than this underlining method. However, since the underlining method was already used, it's probably not worth the effort.
There was a problem hiding this comment.
The bulleted lists should not be escaped, and each list item should be all on one line.
There was a problem hiding this comment.
I would strongly prefer we convert reStructuredText files to Markdown, which is much more human-readable. Having just one markup format would also simplify doc viewing, as users would only need one rendering tool.
There was a problem hiding this comment.
Many strange artifacts left over from the conversion from reStructuredText to Markdown, as you can see by clicking the ellipsis > View File. See #3148 for instructions on using pandoc to convert automatically.
| bin/git-fleximod -- Script to manage the needed sub-component source directories (handled with git submodule) | ||
| py_env_create ----- Script to setup the python environment for CTSM python tools using conda | ||
| python ------------ Python modules used in tools and testing and automated checking of ALL CTSM python scripts | ||
| doc --------------- Documentation of CTSM |
There was a problem hiding this comment.
Why the deleted periods and added whitespace here and elsewhere?
Description of changes
See title
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #2761
Are answers expected to change (and if so in what way)?
No
Any User Interface Changes (namelist or namelist defaults changes)?
No
Does this create a need to change or add documentation? Did you do so?
No
Testing performed, if any:
None needed